Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #180 by enhancing static type analysis #184

Merged
merged 7 commits into from
Mar 16, 2017
Merged

Fix #180 by enhancing static type analysis #184

merged 7 commits into from
Mar 16, 2017

Conversation

TotalVerb
Copy link
Collaborator

@TotalVerb TotalVerb commented Feb 5, 2017 •
edited
Loading

Instead of using parameters which doesn't always work, we fall back to inference to determine the nth element type in static type analysis. Depends on several other PRs to be merged first.

Fixes #180
Fixes #182

Introduces E539 to fix #180 and W546 to fix #182.

@TotalVerb TotalVerb changed the title Fix #180 by enhancing static type analysis WIP: Fix #180 by enhancing static type analysis Feb 5, 2017
@TotalVerb TotalVerb mentioned this pull request Feb 21, 2017
Open
@TeroFrondelius TeroFrondelius mentioned this pull request Feb 26, 2017
Closed
@TeroFrondelius
Copy link
Contributor

What is needed to get this merged?

@TotalVerb
Copy link
Collaborator Author

The tests need to pass. I'll get around to it tomorrow.

@TotalVerb
Copy link
Collaborator Author

This depends on #179, and currently, #179 hangs on master for what I suspect is related to the lint server. I believe that hang wasn't detected by CI because it failed before the server code was tested. I'll have to investigate that first.

@TotalVerb
Copy link
Collaborator Author

Now that #179 is in, I'll rebase this tonight. Hopefully it should be ready soon.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 88.125% when pulling 41addc4 on TotalVerb:fw/fix-180 into 1dfcfd4 on tonyhffong:master.

@coveralls
Copy link

coveralls commented Mar 8, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 88.125% when pulling 41addc4 on TotalVerb:fw/fix-180 into 1dfcfd4 on tonyhffong:master.

@coveralls
Copy link

coveralls commented Mar 8, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.04%) to 87.876% when pulling ec23b40 on TotalVerb:fw/fix-180 into 1dfcfd4 on tonyhffong:master.

@coveralls
Copy link

coveralls commented Mar 8, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.1%) to 87.785% when pulling 4b02fef on TotalVerb:fw/fix-180 into 1dfcfd4 on tonyhffong:master.

@coveralls
Copy link

coveralls commented Mar 14, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.2%) to 87.733% when pulling 2d8810f on TotalVerb:fw/fix-180 into 14da1fc on tonyhffong:master.

@coveralls
Copy link

coveralls commented Mar 15, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 88.849% when pulling bf2e780 on TotalVerb:fw/fix-180 into 14da1fc on tonyhffong:master.

@TotalVerb TotalVerb changed the title WIP: Fix #180 by enhancing static type analysis Fix #180 by enhancing static type analysis Mar 15, 2017
@TotalVerb
Copy link
Collaborator Author

@TeroFrondelius @Michael-Klassen If you'd like to look this over, this is now ready for review. Otherwise, I'll merge it by March 17.

@coveralls
Copy link

coveralls commented Mar 15, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 88.849% when pulling 6680e1b on TotalVerb:fw/fix-180 into 14da1fc on tonyhffong:master.

@Michael-Klassen Michael-Klassen merged commit a3466d9 into tonyhffong:master Mar 16, 2017
@TeroFrondelius TeroFrondelius mentioned this pull request Mar 18, 2017
Closed
@TotalVerb TotalVerb mentioned this pull request Mar 19, 2017
Closed
TotalVerb pushed a commit that referenced this pull request Mar 19, 2017
@Michael-Klassen @TotalVerb
Merge pull request #184 from TotalVerb/fw/fix-180
2431b3f 
Fix #180 by enhancing static type analysis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E418 issues Lint crashes when assigning Union{} as tuple
4 participants
@TotalVerb @TeroFrondelius @coveralls @Michael-Klassen